Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint: change tests #3662

Closed
wants to merge 19 commits into from
Closed

mint: change tests #3662

wants to merge 19 commits into from

Conversation

pysel
Copy link
Member

@pysel pysel commented Dec 8, 2022

x/mint tests run using osmocli

@faddat
Copy link
Member

faddat commented Dec 12, 2022

dude this is great!

@ValarDragon is it okay to merge into your branch?

@pysel
Copy link
Member Author

pysel commented Dec 12, 2022

I think it is okay as we discussed that already 👍. Shall I merge?

Base automatically changed from dev/osmocli_test_fix to main December 12, 2022 17:55
@ValarDragon
Copy link
Member

I don't know that we can merge this easily unfortunately -- mint wasn't adjusted in the initial PR because mint's differences from everything else are inherited from the SDK.

So this is actually mint-CLI breaking

@ValarDragon
Copy link
Member

ValarDragon commented Dec 21, 2022

Hrmm, I think we should make a github issue for breaking mint CLI.

I want to do this, we just need to get changelog set, release in a minor version and communicate to integrators.

Going to close PR, b/c conflicts and rebase needed.

I think we can PR the same change as a clean PR, and then get changelog/integrator comm plan figured out, and ship it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants